Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the mapolicy train issue #968

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

FahmidMorshed
Copy link
Contributor

The trained MARL policies were not performing as expected because the parent class (MultiAgentPolicyManager) needed a train function.

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below

Fixes #967

The trained MARL policies were not performing as expected because the parent class (MultiAgentPolicyManager) needed a train function.
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #968 (dcc1493) into master (66b7fc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          72       72           
  Lines        5394     5398    +4     
=======================================
+ Hits         4899     4903    +4     
  Misses        495      495           
Flag Coverage Δ
unittests 90.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tianshou/policy/multiagent/mapolicy.py 85.41% <100.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Trinkle23897 Trinkle23897 merged commit bf78410 into thu-ml:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in MultiAgentPolicyManager - and Fix
3 participants