-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/fix trainer fct notebooks #1009
Docs/fix trainer fct notebooks #1009
Conversation
@opcode81 This is the PR for the issue we discussed today |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 96 96
Lines 7531 7531
=======================================
Hits 6632 6632
Misses 899 899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The build fails because you committed a different python version to the notebook metadata. Could you undo this pls? |
The build on windows fails, but it has nothing to do with the changes here. Seems some caching problem in CI. If it appears on master, I'm gonna solve it in a separate PR. Merging this, thanks for the docs fixes! |
poe format
poe lint
andpoe type-check
poe test
(or a subset of them with
poe test-reduced
) ,and they passpoe doc-build
This PR resolves #1008