Maintenance update #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2024
|
Once merged, I'll follow up with a release. 🙂 |
|
|
threema-eduard
requested changes
Aug 21, 2024
|
LGTM apart from the little comments above! |
threema-lenny
commented
Aug 21, 2024
In https://gateway.threema.ch/de/developer/e2e, the 'padded-data' description states that the sum of 'data' and 'pad-length' should be at least 32. This was not enforced by the code.
threema-lenny
force-pushed
the
maintenance
branch
from
b2b090c to
aa55fac
Compare
threema-eduard
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #66
Includes #67
Supersedes #68