-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare APNS support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new payload field `type` that may be either `gcm` or `apns`. If no type is specified, it defaults to `gcm` (for backwards compatibility).
Extract push related code into separate module.
This way, it's impossible to pass an ApnsToken to the GCM notification function.
dbrgn
force-pushed
the
apns
branch
2 times, most recently
from
April 25, 2018 08:26
fec0bdc
to
9907346
Compare
Note: The cargo-audit warning is a false positive: rustsec/rustsec#17 and dtolnay/semver#172 |
dbrgn
force-pushed
the
apns
branch
2 times, most recently
from
April 25, 2018 15:00
11c16c6
to
714c9e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new payload field
type
that may be eithergcm
orapns
.If no type is specified, it defaults to
gcm
(for backwards compatibility).Work in progress.