Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to secret env vars for containers #502

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

muhamadazmy
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #502 into master will increase coverage by 0.11%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   36.01%   36.13%   +0.11%     
==========================================
  Files          75       75              
  Lines        5093     5101       +8     
==========================================
+ Hits         1834     1843       +9     
+ Misses       2995     2992       -3     
- Partials      264      266       +2
Impacted Files Coverage Δ
.../types/provision/tfgrid_reservation_container_1.go 100% <ø> (ø) ⬆️
.../provision/tfgrid_reservation_statsaggregator_1.go 0% <0%> (ø) ⬆️
pkg/container/opts.go 11.45% <100%> (ø) ⬆️
pkg/gedis/commands_provision.go 42.24% <100%> (+3.33%) ⬆️
pkg/provision/container.go 60.13% <16.66%> (-1.91%) ⬇️
pkg/provision/zdb.go 45.09% <75%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6125b69...f3a0354. Read the comment docs.

@muhamadazmy muhamadazmy merged commit e972efe into master Feb 11, 2020
@muhamadazmy muhamadazmy deleted the container-secret-env branch February 11, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants