support multiple subdomains of the name gateways #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawdaGastan
requested review from
muhamadazmy,
delandtj,
mariobassem,
ashraffouda and
xmonader
as code owners
rawdaGastan
force-pushed
the
development_support_subdomain_gateway_name
branch
3 times, most recently
from
205562b to
84a77ff
Compare
muhamadazmy
reviewed
Jun 11, 2024
pkg/gateway/gateway.go
Outdated
Comment on lines
579
to
581
| if len(subdomains) >= 2 { | ||
| reservedName = subdomains[len(subdomains)-1] | ||
| } |
There was a problem hiding this comment.
there is no need for this if statement here this can be like
Suggested change
| if len(subdomains) >= 2 { | |
| reservedName = subdomains[len(subdomains)-1] | |
| } | |
| reservedName = subdomains[len(subdomains)-1] |
rawdaGastan
force-pushed
the
development_support_subdomain_gateway_name
branch
from
84a77ff to
1038e59
Compare
muhamadazmy
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
<subdomain>.<name>in gateway #2354