Events stream #1855
Merged
Events stream #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves on the internal delivery system of the events so instead of using zbus pub/sub streams we use redis streams which is much more powerful as follows: - Events are scanned from the chain. If the events subsystem is down during the delivery of the event, the missed blocsk will be rescanned - Received events are pushed to capped streams (length of 1024) event - Consumers groups are created one per consumer. So each group has a max if one group. this allows us to track pending messages, and able to processes un acknowledge messages - To prvent the node from getting stuck an event ack is sent back if handling failed or succeeded. other protection mechanism is implemented in the system to clean up.
muhamadazmy
requested review from
maxux,
delandtj,
LeeSmet and
DylanVerstraete
as code owners
xmonader
reviewed
Nov 25, 2022
cmds/modules/provisiond/events.go
Outdated
| ) | ||
|
|
||
| type ContractEventHandler struct { | ||
| node uint32 | ||
| pool substrate.Manager | ||
| engine provision.Engine | ||
| cl zbus.Client | ||
| events *events.RedisConsumer |
There was a problem hiding this comment.
shouldn't that be redisConsumer instead of events for readability?
xmonader
previously approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite event distribution system
This improves on the internal delivery system of the events so instead of using zbus pub/sub streams we use redis streams which is much more powerful as follows:
during the delivery of the event, the missed blocsk will be rescanned
if one group. this allows us to track pending messages, and able to
processes un acknowledge messages
handling failed or succeeded. other protection mechanism is
implemented in the system to clean up.