Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework workload update order #1431

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Rework workload update order #1431

merged 3 commits into from
Oct 14, 2021

Conversation

OmarElawady
Copy link
Contributor

Updates are done (semantically) in this order:

  1. deletes first in reverse dependency order (zmachine -> disks)
  2. updates and creations are merged and deployed in order (disk create => disk update => zmachine update => zmachine create)

muhamadazmy
muhamadazmy reviewed Oct 14, 2021
View reviewed changes
pkg/provision/engine.go Outdated Show resolved Hide resolved
pkg/provision/engine.go Show resolved Hide resolved
@muhamadazmy muhamadazmy merged commit df48f8b into main Oct 14, 2021
@muhamadazmy muhamadazmy deleted the zos3/update-order branch October 14, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@delandtj delandtj Awaiting requested review from delandtj

@DylanVerstraete DylanVerstraete Awaiting requested review from DylanVerstraete

@LeeSmet LeeSmet Awaiting requested review from LeeSmet

@maxux maxux Awaiting requested review from maxux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarElawady @muhamadazmy