Add prometheus endpoint and nft rules #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarElawady
requested review from
delandtj,
DylanVerstraete,
LeeSmet,
maxux and
muhamadazmy
as code owners
muhamadazmy
reviewed
Oct 11, 2021
| @@ -190,16 +190,19 @@ func (c *QuantumSafeFSConfig) Challenge(w io.Writer) error { | |||
| return nil | |||
| } | |||
|
|
|||
| type QuatumSafeFS struct { | |||
| type QuantumSafeFS struct { | |||
OmarElawady
force-pushed
the
zos3/qsfs-metrics
branch
from
469c6e0 to
6a12a73
Compare
muhamadazmy
reviewed
Oct 11, 2021
pkg/network/qsfs.go
Outdated
| if err != nil { | ||
| return "", "", err | ||
| } | ||
| ip, err := n.waitYggIPs(netNSName) |
There was a problem hiding this comment.
You don't need to wait at all, the Ip is detereminstic and is calcualted int he attachYgg function
OmarElawady
force-pushed
the
zos3/qsfs-metrics
branch
from
6d7e7df to
f7055a4
Compare
muhamadazmy
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.