Feat/provisiond message bus #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhamadazmy
requested changes
Jun 4, 2021
muhamadazmy
requested changes
Jun 9, 2021
DylanVerstraete
requested review from
delandtj,
LeeSmet and
maxux
as code owners
also improve the message bus retry mechanism
muhamadazmy
force-pushed
the
feat/provisiond-message-bus
branch
from
9629bee to
39d254b
Compare
User of the library does not need to know about keys, or types and not having the twinid in ctx is a programming error, not runtime, hence a panic is raised, not returning a bad request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.