Support ygg adderesses in containers #1201
Conversation
muhamadazmy
requested review from
delandtj,
DylanVerstraete,
LeeSmet and
maxux
as code owners
pkg/network/networker.go
Outdated
| @@ -285,7 +286,7 @@ func (n networker) ZDBPrepare(hw net.HardwareAddr) (string, error) { | |||
|
|
|||
| } | |||
|
|
|||
| return netNSName, n.createMacVlan(ZDBIface, hw, ips, routes, netNs) | |||
| return netNSName, n.createMacVlan(ZDBIface, types.YggBridge, hw, ips, routes, netNs) | |||
There was a problem hiding this comment.
The yggdrasil macvlan for zdbs should be installed next to the already existing macvlan, not replace it
There was a problem hiding this comment.
Ah right, so zdb will has both as well. right. This means we need another interface in the zdb container ?
There was a problem hiding this comment.
indeed, everything with ygg IP will have a dedicated interface for that. Later when a vm can have an ygg IP, it will also create a dedicated tap iface on the ygg bridge next to the existing ones. That way traffic flow is nicely separated.
One public and the other yggdrasil
…zos into zos3/ygg-ip-in-containers
| func (n networker) ZDBPrepare(hw net.HardwareAddr) (string, error) { | ||
| func (n networker) ZDBPrepare(id string) (string, error) { | ||
|
|
||
| hw := ifaceutil.HardwareAddrFromInputBytes([]byte("pub:" + id)) |
There was a problem hiding this comment.
I think the "pub:" prefix should not be here, so the input is the same as it was previously for this iface. Otherwise, if a node has a zdb running and reboots after this update, it will generate a new mac address, resulting in a different ip6 from slaac, which will mean the ipv6 originally returned in the result (which is probably used) is not valid anymore
|
I can drop the prefix, but we already are not backward compatible with
zos2. So this is all for fresh nodes
…On Thu, Feb 25, 2021, 11:26 PM Lee Smet ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In pkg/network/networker.go
<#1201 (comment)>:
> @@ -240,7 +243,10 @@ func (n *networker) Leave(networkdID pkg.NetID, containerID string) error {
// ZDBPrepare sends a macvlan interface into the
// network namespace of a ZDB container
-func (n networker) ZDBPrepare(hw net.HardwareAddr) (string, error) {
+func (n networker) ZDBPrepare(id string) (string, error) {
+
+ hw := ifaceutil.HardwareAddrFromInputBytes([]byte("pub:" + id))
I think the "pub:" prefix should not be here, so the input is the same as
it was previously for this iface. Otherwise, if a node has a zdb running
and reboots after this update, it will generate a new mac address,
resulting in a different ip6 from slaac, which will mean the ipv6
originally returned in the result (which is probably used) is not valid
anymore
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1201 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACTKDA3WXCK2W7EKOBJEKHLTA3E7PANCNFSM4YGO3M6A>
.
|
|
Hmm yes, if we only use it for grid3 that makes sense. Looks good, but CI errors |
No description provided.