Prefetch the node identity

Prefetch the node identity and use it for uptime updates

cmds/modules/noded/main.go

@@ -243,6 +243,16 @@ func action(cli *cli.Context) error {
 		}
 	}()
 
+	log.Info().Uint32("twin", twin).Msg("node has been registered")
+	log.Debug().Msg("start message bus")
+	identityd := stubs.NewIdentityManagerStub(redis)
+	sk := ed25519.PrivateKey(identityd.PrivateKey(ctx))
+	id, err := substrate.NewIdentityFromEd25519Key(sk)
+	log.Info().Str("address", id.Address()).Msg("node address")
+	if err != nil {
+		return err
+	}
+
 	// uptime update
 	go func() {
 		defer log.Info().Msg("uptime reporting exited permanently")
@@ -253,7 +263,7 @@ func action(cli *cli.Context) error {
 				}
 			}()
 
-			err = uptime(ctx, redis)
+			err = uptime(ctx, id)
 			return err
 		}
 
@@ -270,16 +280,6 @@ func action(cli *cli.Context) error {
 		}
 	}()
 
-	log.Info().Uint32("twin", twin).Msg("node has been registered")
-	log.Debug().Msg("start message bus")
-	identityd := stubs.NewIdentityManagerStub(redis)
-	sk := ed25519.PrivateKey(identityd.PrivateKey(ctx))
-	id, err := substrate.NewIdentityFromEd25519Key(sk)
-	log.Info().Str("address", id.Address()).Msg("node address")
-	if err != nil {
-		return err
-	}
-
 	return runMsgBus(ctx, sub, id)
 }
 

cmds/modules/noded/register.go

@@ -2,41 +2,26 @@ package noded
 
 import (
 	"context"
-	"crypto/ed25519"
 	"time"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog/log"
 	"github.com/shirou/gopsutil/host"
 	"github.com/threefoldtech/substrate-client"
-	"github.com/threefoldtech/zbus"
 	"github.com/threefoldtech/zos/pkg/environment"
-	"github.com/threefoldtech/zos/pkg/stubs"
 )
 
 const (
 	reportUptimeEvery = 40 * time.Minute
 )
 
-func uptime(ctx context.Context, cl zbus.Client) error {
-	var (
-		mgr = stubs.NewIdentityManagerStub(cl)
-	)
-
+func uptime(ctx context.Context, id substrate.Identity) error {
 	subMgr, err := environment.GetSubstrate()
 	if err != nil {
 		return err
 	}
 
-	busCtx, cancel := context.WithTimeout(ctx, 10*time.Second)
-	defer cancel()
-	sk := ed25519.PrivateKey(mgr.PrivateKey(busCtx))
-	id, err := substrate.NewIdentityFromEd25519Key(sk)
-	if err != nil {
-		return err
-	}
-
 	update := func(uptime uint64) (types.Hash, error) {
 		sub, err := subMgr.Substrate()
 		if err != nil {