replace has gpu with num gpu #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmonader
reviewed
Jun 21, 2023
xmonader
reviewed
Jun 21, 2023
| @@ -70,7 +80,7 @@ func nodeFromDBNode(info db.Node) types.Node { | |||
| RentedByTwinID: uint(info.RentedByTwinID), | |||
| SerialNumber: info.SerialNumber, | |||
| Power: types.NodePower(info.Power), | |||
| HasGPU: info.HasGPU, | |||
| NumGPUs: getNumGPUs(info.HasGPU), | |||
There was a problem hiding this comment.
should be NumGPU not NumGPUs similar to runtime.NumCPU https://pkg.go.dev/runtime#NumCPU
There was a problem hiding this comment.
the field will be num_gpus right? I'd rather keep them consistent
There was a problem hiding this comment.
I agree, let's stay indeed consistent with the field in tfchain, i updated the title to make it num_gpu
threefoldtech/tfchain#756
xmonader
reviewed
Jun 21, 2023
xmonader
reviewed
Jun 21, 2023
xmonader
reviewed
Jun 21, 2023
alichaddad
force-pushed
the
development_num_gpus
branch
from
ab15ba9
to
5d0e091
Compare
alichaddad
force-pushed
the
development_num_gpus
branch
from
5d0e091
to
3a7e555
Compare
xmonader
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
#210
Checklist