Development fix dao proposal veto #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renauter
requested review from
brandonpille,
LeeSmet,
muhamadazmy and
sameh-farouk
as code owners
| @@ -170,6 +170,7 @@ pub mod pallet { | |||
| ProposalMissing, | |||
| WrongIndex, | |||
| DuplicateVote, | |||
| DuplicateVeto, | |||
There was a problem hiding this comment.
Can you also update the error list in the go client?
There was a problem hiding this comment.
I wanted to do this but after I realized it is not needed since there is no pallet-dao call available in go client
correct me if I am wrong
There was a problem hiding this comment.
True! Let's not add it then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A duplicate veto from a council member should not be allowed.
Make sure this can not happen by sending appropriate error message in
veto()call if a veto from such council member is already registered.Related Issues: