feat!(runtime): removal of sudo #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanVerstraete
requested review from
brandonpille,
renauter,
robvanmieghem and
LeeSmet
as code owners
brandonpille
reviewed
Jul 5, 2023
| Dao: pallet_dao::{Pallet, Call, Storage, Event<T>}, | ||
| Utility: pallet_utility::{Pallet, Call, Event}, | ||
| Historical: pallet_session::historical::{Pallet}, | ||
| // System support |
There was a problem hiding this comment.
Could you also fix the go client? It has a list of modules errors (in utils.go) and we map from id to error there. Will need to remove the id of Sudo pallet.
There was a problem hiding this comment.
Sure, but honestly having a staticly typed moduleErrors list is quite a hastle to maintain. This should actually come from the metadata.
There was a problem hiding this comment.
I agree it's a hastle. Does the metadata also show the error information?
renauter
approved these changes
Jul 5, 2023
|
@renauter references in the chainspecs need to stay since the chainspecs are genesis configurations and are static forever. I'll remove any references in the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also order and number runtime pallets for future compatibility