Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pallets): restructure pallet smart contract #755

Merged
merged 14 commits into from
Jun 29, 2023

Conversation

renauter
Copy link
Collaborator

Rework pallet smart contract

Related to:

@renauter renauter marked this pull request as ready for review June 28, 2023 01:10
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just notice quite some comments that don't really add any value to the code. I think it's better to leave those out. But I'm also ok if you keep them.

Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. Thanks!

@renauter renauter merged commit 2f8a65d into development Jun 29, 2023
@renauter renauter deleted the development_restructure_pallet_smart_contract branch June 29, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants