Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client:go): uptime should not retry #710

Merged
merged 1 commit into from
May 30, 2023
Merged

fix(client:go): uptime should not retry #710

merged 1 commit into from
May 30, 2023

Conversation

muhamadazmy
Copy link
Member

No description provided.

brandonpille
brandonpille approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

DylanVerstraete
DylanVerstraete approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@DylanVerstraete DylanVerstraete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will update the PR name to have the commit style of our repo.

@DylanVerstraete DylanVerstraete changed the title uptime should not retry fix(client:go): uptime should not retry May 30, 2023
@DylanVerstraete DylanVerstraete merged commit 5461023 into development May 30, 2023
@DylanVerstraete DylanVerstraete deleted the uptime-only-call-once branch May 30, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonpille brandonpille brandonpille approved these changes

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@renauter renauter Awaiting requested review from renauter renauter is a code owner

@robvanmieghem robvanmieghem Awaiting requested review from robvanmieghem

@LeeSmet LeeSmet Awaiting requested review from LeeSmet LeeSmet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhamadazmy @brandonpille @DylanVerstraete