fix: farming policies ordering and assignment #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renauter
reviewed
May 26, 2023
| @@ -176,7 +176,10 @@ impl<B: Ord> PartialOrd for FarmingPolicy<B> { | |||
| impl<B: Ord> Ord for FarmingPolicy<B> { | |||
| fn cmp(&self, other: &Self) -> Ordering { | |||
| match self.farm_certification.cmp(&other.farm_certification) { | |||
| Ordering::Equal => self.node_certification.cmp(&other.node_certification), | |||
| Ordering::Equal => match self.node_certification.cmp(&other.node_certification) { | |||
There was a problem hiding this comment.
this cmp() is set for being able to use sort() on FarmingPolicy, correct?
For our usage we only care about the creation time so why id ordering is not enough?
There was a problem hiding this comment.
Sorting by ID will always make sure policies are sorted by creation time since ID is incremental. I also implemented like this so the tests would be work.
DylanVerstraete
requested review from
brandonpille,
robvanmieghem and
LeeSmet
as code owners
|
@renauter thanks for reviewing and fixing the test. I think we are good now :-) |
renauter
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't order farming policies on creation date / id, causing miss assignment of policies on testnet. #664