feat(benchmark): benchmarking pallets [2/4]

[renauter]

Benchmarking pallets:

• burning
• dao
• kvstore
• validator set
• validator
• runtime upgrade

Solves part of

• Benchmark all extrinsics #394

[DylanVerstraete]

Awesome!

A thing to note and maybe think about is that weight also needs to be adjusted given the size of an input. For example if a user calls burn with a huge description, the weight should grow or shrink based on the size of the input.

But maybe we can keep this for future improvements.

[renauter]

the weight should grow or shrink based on the size of the input.

I don t see how to set an adaptive weight for a given extrinsic depending on its input size.
But maybe providing a maximized input size for the default benchmark would be the best approach to avoid "not enough weight" cases ?

[DylanVerstraete]

I don t see how to set an adaptive weight for a given extrinsic depending on its input size. But maybe providing a maximized input size for the default benchmark would be the best approach to avoid "not enough weight" cases ?

See https://github.com/paritytech/substrate/blob/655b81cf3ce607b87a293b67d14662ed433a3863/frame/system/src/lib.rs#LL419C48-L419C55 for example