feat(client:go): add batch create contract #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanElawady
requested review from
DylanVerstraete,
brandonpille,
renauter,
robvanmieghem and
LeeSmet
as code owners
brandonpille
reviewed
May 3, 2023
| @@ -233,6 +233,113 @@ func (s *Substrate) CreateNodeContract(identity Identity, node uint32, body stri | |||
| return s.GetContractWithHash(node, h) | |||
| } | |||
|
|
|||
| // BatchCreateContractData struct for batch create contract | |||
| type BatchCreateContractData struct { | |||
| Node uint32 | |||
There was a problem hiding this comment.
Can you add json tags please? We need them for the web3 proxy.
| // and other fields are ignored | ||
| Name string | ||
|
|
||
| hexHash HexHash |
There was a problem hiding this comment.
This field will be private, it doesn't start with upper case.
There was a problem hiding this comment.
that was intentional as it is generated internally and not provided by user, should it be public?
There was a problem hiding this comment.
If you don't return this object then no there is no use to it.
DylanVerstraete
approved these changes
May 4, 2023
brandonpille
approved these changes
May 4, 2023
| // and other fields are ignored | ||
| Name string | ||
|
|
||
| hexHash HexHash |
There was a problem hiding this comment.
If you don't return this object then no there is no use to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add batch and batch all for create contracts