Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lower discount level thresholds #638

Merged
merged 6 commits into from
Mar 13, 2023
Merged

feat: lower discount level thresholds #638

merged 6 commits into from
Mar 13, 2023

Conversation

renauter
Copy link
Collaborator

@renauter renauter marked this pull request as ready for review March 10, 2023 14:21
DylanVerstraete
DylanVerstraete approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@DylanVerstraete DylanVerstraete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, also include a PR to change docs on library + Add ADR describing the change

brandonpille
brandonpille approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

substrate-node/pallets/pallet-smart-contract/src/cost.rs Show resolved Hide resolved
@renauter
Copy link
Collaborator Author

also include a PR to change docs on library + Add ADR describing the change

@DylanVerstraete DylanVerstraete merged commit 82f7113 into development Mar 13, 2023
@DylanVerstraete DylanVerstraete deleted the development_lower_discount_level branch March 13, 2023 13:24
@mohamedamer453 mohamedamer453 mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonpille brandonpille brandonpille approved these changes

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renauter @brandonpille @DylanVerstraete