Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration v15 did not set storage version correctly #598

Closed
DylanVerstraete opened this issue Feb 6, 2023 · 1 comment
Closed

Migration v15 did not set storage version correctly #598

DylanVerstraete opened this issue Feb 6, 2023 · 1 comment
Assignees
@DylanVerstraete
Labels
type_bug Something isn't working
Milestone
2.3.0

Comments

@DylanVerstraete
Copy link
Contributor

On devnet we applied migration V15: https://github.com/threefoldtech/tfchain/blob/development/substrate-node/pallets/pallet-tfgrid/src/migrations/v15.rs

But this migration did not set the storage version to V15 properly:

tfchain/substrate-node/pallets/pallet-tfgrid/src/migrations/v15.rs

Line 82 in 94a1357

PalletVersion::<T>::set(types::StorageVersion::V14Struct);

Either we skip this migration for following releases on devnet, or we create a new migration for devnet alone which sets the storage version to V15.
@DylanVerstraete DylanVerstraete added the type_bug Something isn't working label Feb 6, 2023
@DylanVerstraete DylanVerstraete moved this to 🏗 In progress in 3.9.0 Feb 6, 2023
@DylanVerstraete DylanVerstraete modified the milestones: 2.2.0, 2.3.0 Feb 6, 2023
DylanVerstraete added a commit that referenced this issue Feb 6, 2023
@DylanVerstraete
fix: migration V15 for devnet #598
e87586d
@DylanVerstraete DylanVerstraete self-assigned this Feb 6, 2023
@DylanVerstraete DylanVerstraete moved this from 🏗 In progress to 👀 Verification in 3.9.0 Feb 6, 2023
@DylanVerstraete
Copy link
Contributor Author

Fixed and verified

image

@github-project-automation github-project-automation bot moved this from 👀 Verification to ✅ Done in 3.9.0 Feb 6, 2023
DylanVerstraete added a commit that referenced this issue Apr 12, 2023
@DylanVerstraete @renauter
@omahs @LeeSmet @robvanmieghem @brandonpille
2.3.0 (#655)
140c58c 
* feat: rework documentation (#571)

* doc: service consumer contract flow (#567)

* fix: farming policies map ids (#591)

* chore: reset runtime migrations

* feat: delete twin is not allowed (#586)

* fix: typos (#595)

* fix: locked balances (#590)

* feat: allow twin to connect to a relay (#570)

* chore: bump to version 2.3.0-rc1 (specVersion: 124)

* feat: add node power (#592)

* chore: update ADR docs

* chore: bump to version 2.3.0-rc2 (specVersion: 125)

* chore: rework logging pallet smart contract

* fix: allow numbers in relay addresses

* chore: bump to version 2.3.0-rc3 (specVersion: 125)

* fix: migration V15 for devnet #598

* chore: bump to version 2.3.0-rc4 (specVersion: 127)

* chore: restore V15 migration

* chore: update dev chain spec

* fix: soften serial number validation (#603)

* chore: set max length of serial number to 128 bytes

* chore: align tft bridge dependency

* chore: update default dev chainspec

* chore: revert default dev bridge validators chainspec

* Drop unused structopt dependency

This also removes some unused child dependencies

Signed-off-by: Lee Smet <lee.smet@hotmail.com>

* Set the substrate node default chart image to ghcr.io

* fix: rework balances migrations

* chore: refactor

* feat: also remove contract and lock if twin is deleted

* chore: add writes

* chore: resolve comment

* chore: fix ci

* chore: resolve pr comments

* chore: add log

* Update build_test.yaml to use the new runner (#617)

* chore: remove serial valdiation (#616)

* chore: bump to version 2.3.0-rc6 (specVersion: 129)

* chore: rework chart #620

* fix: discount calculation handle variable billing frequency (#626)

* fix: migrations for v2.3.0 (#627)

* chore: bump to version 2.3.0-rc7 (specVersion: 130)

* fix: soften node city/country validation

* chore: bump to version 2.3.0-rc8 (specVersion: 131)

* chore: update cargo lock

* chore: bump version to 2.3.0

---------

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
Co-authored-by: Erwan Renaut <73958772+renauter@users.noreply.github.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Co-authored-by: Lee Smet <lee.smet@hotmail.com>
Co-authored-by: Rob Van Mieghem <robvanmieghem@gmail.com>
Co-authored-by: Brandon <brandon@threefold.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DylanVerstraete DylanVerstraete

Labels
type_bug Something isn't working
Projects
No open projects
3.9.0
Status: ✅ Done
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@DylanVerstraete