Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Material.type mutable #1402

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Make Material.type mutable #1402

merged 1 commit into from
Dec 14, 2024

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Dec 14, 2024

Fixes #1399

TypeScript is weird in that it doesn't allow setting readonly property in subclass constructors, which is a clear use-case for the type property

@Methuselah96 Methuselah96 merged commit d41b758 into master Dec 14, 2024
5 checks passed
@Methuselah96 Methuselah96 deleted the material-type-mutable branch December 14, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material type became read-only
1 participant