Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: AssetEnabled upgrade #1735

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

fixup! Exchanges: Rename StoreAssetPairStore

bfa72e2
Select commit
Loading
Failed to load commit list.
Open

Config: AssetEnabled upgrade #1735

fixup! Exchanges: Rename StoreAssetPairStore
bfa72e2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 29, 2024 in 0s

37.38% (+0.24%) compared to 105591b

View this Pull Request on Codecov

37.38% (+0.24%) compared to 105591b

Details

Codecov Report

Attention: Patch coverage is 71.68142% with 64 lines in your changes missing coverage. Please review.

Project coverage is 37.38%. Comparing base (105591b) to head (bfa72e2).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
exchanges/exchange.go 44.44% 10 Missing and 15 partials ⚠️
exchanges/binance/binance_wrapper.go 33.33% 4 Missing and 2 partials ⚠️
exchanges/bitfinex/bitfinex_wrapper.go 66.66% 3 Missing and 2 partials ⚠️
exchanges/bitmex/bitmex_wrapper.go 66.66% 3 Missing and 2 partials ⚠️
exchanges/kraken/kraken_wrapper.go 66.66% 3 Missing and 2 partials ⚠️
exchanges/deribit/deribit_wrapper.go 42.85% 2 Missing and 2 partials ⚠️
exchanges/btse/btse_wrapper.go 76.92% 2 Missing and 1 partial ⚠️
exchanges/bybit/bybit_wrapper.go 25.00% 2 Missing and 1 partial ⚠️
exchanges/huobi/huobi_wrapper.go 80.00% 2 Missing and 1 partial ⚠️
exchanges/kucoin/kucoin_wrapper.go 80.00% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
+ Coverage   37.13%   37.38%   +0.24%     
==========================================
  Files         414      416       +2     
  Lines      180198   178480    -1718     
==========================================
- Hits        66925    66723     -202     
+ Misses     105413   104001    -1412     
+ Partials     7860     7756     -104     
Files with missing lines Coverage Δ
backtester/engine/setup.go 58.59% <100.00%> (+0.70%) ⬆️
config/config.go 87.30% <ø> (+0.25%) ⬆️
config/versions/v3.go 100.00% <100.00%> (ø)
currency/manager.go 93.66% <100.00%> (-0.35%) ⬇️
exchanges/sharedtestvalues/sharedtestvalues.go 76.59% <100.00%> (+11.28%) ⬆️
exchanges/binanceus/binanceus_wrapper.go 41.04% <60.00%> (+0.15%) ⬆️
exchanges/btse/btse_wrapper.go 44.63% <76.92%> (+0.85%) ⬆️
exchanges/bybit/bybit_wrapper.go 46.63% <25.00%> (+3.42%) ⬆️
exchanges/huobi/huobi_wrapper.go 39.60% <80.00%> (-0.37%) ⬇️
exchanges/kucoin/kucoin_wrapper.go 31.86% <80.00%> (+0.12%) ⬆️
... and 6 more

... and 45 files with indirect coverage changes