Bitstamp: Add missing API fields #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beadko
commented
Mar 30, 2024
| assert.Equal(t, 0.50000000, res.AmountAtCreate, "AmountAtCreate should match") | ||
| assert.Equal(t, 110.00, res.LimitPrice, "LimitPrice should match") | ||
| assert.Equal(t, "1234123412341234", res.ClientOrderID, "ClientOrderID should match") | ||
| assert.Equal(t, "BTC/USD", res.Market, "Market should match") |
There was a problem hiding this comment.
One comment was regarding the Currency is not set for []Order type. Bitstamp open orders for markets do not include currency in the response so I have added "Market" which was missing
Beadko
force-pushed
the
bugfix/bitstamp_add_missing_fields
branch
from
b5c530f to
45384a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
+ Coverage 36.03% 36.05% +0.01%
==========================================
Files 411 411
Lines 177750 177754 +4
==========================================
+ Hits 64061 64088 +27
+ Misses 105839 105816 -23
Partials 7850 7850
|
gloriousCode
requested changes
Apr 12, 2024
gloriousCode
approved these changes
Apr 14, 2024
shazbert
requested changes
Apr 14, 2024
shazbert
added
reconstructing
thrasher-
changed the title
Beadko
force-pushed
the
bugfix/bitstamp_add_missing_fields
branch
from
7edc42d to
e6caa92
Compare
shazbert
approved these changes
May 5, 2024
shazbert
added
review me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Issues picked up during PR#1423 but were considered out of scope. In addition, the main error checks changed from assert to require.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist