-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exchanges/wrappers: shift bespoke fetch ticker, orderbook and accountinfo #1440
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board with the simplification. There are a few tests that aren't needed that call the newly moved Base functions eg Binanceus TestFetchAccountInfo
cmd/exchange_wrapper_standards/exchange_wrapper_standards_test.go
Outdated
Show resolved
Hide resolved
cmd/exchange_wrapper_standards/exchange_wrapper_standards_test.go
Outdated
Show resolved
Hide resolved
cmd/exchange_wrapper_standards/exchange_wrapper_standards_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott <gloriousCode@users.noreply.github.com>
Tests are showing issue in retrieving the orderbook and ticker. Something I can replicate:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes! Looks like this pr continues to open 🥫 🪱
PR Description
This PR stops potential error obfuscation. The problem is ongoing in batch operations. So you may have a misconfigured pair which will not be present in memory, the entire batch is loaded but that error forces an update slowing everything down, which will occur over and over again.
FetchAccountInfo
,FetchOrderbook
,FetchTicker
to exchange.go as base methods.Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
x
in[]
as item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist