exchanges: Update Poloniex exchange API #1351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gloriousCode
changed the title
shazbert
requested changes
Sep 18, 2023
exchanges/mock/common.go
Outdated
| if err != nil { | ||
| return vals, err | ||
| if strings.EqualFold(err.Error(), "json: cannot unmarshal array into Go value of type map[string]interface {}") { |
There was a problem hiding this comment.
Can you please have a valid test case for this?
exchanges/mock/common.go
Outdated
| intermediary := make(map[string]interface{}) | ||
| err := json.Unmarshal(payload, &intermediary) | ||
| intermediary := make([]map[string]interface{}, 1, 5) | ||
| intermediary[0] = make(map[string]interface{}) |
There was a problem hiding this comment.
This should be allocated with the json call so can RM this.
| @@ -181,12 +181,14 @@ func HTTPRecord(res *http.Response, service string, respContents []byte) error { | |||
| if jErr != nil { | |||
| return jErr | |||
| } | |||
|
|
|||
| if MatchURLVals(reqVals, mockVals) { | |||
| found = true | |||
There was a problem hiding this comment.
Could you please have a test case for this?
|
|
||
| // MatchBatchAndGetResponse matches a batch of incoming request values with mockdata response | ||
| // values and returns the payload | ||
| func MatchBatchAndGetResponse(mockData []HTTPResponse, requestVals []url.Values) (json.RawMessage, error) { |
exchanges/poloniex/poloniex.go
Outdated
| var resp []SymbolDetail | ||
| path := "/markets" | ||
| if !symbol.IsEmpty() { | ||
| path = fmt.Sprintf("%s/%s", path, symbol) |
There was a problem hiding this comment.
use concatenation instead of fmt.Sprintf across this PR.
| sort.Sort(trade.ByDate(resp)) | ||
| return resp, nil | ||
| } | ||
|
|
||
| // -------------------------------------------------------------------------------------------------------------------- |
| } | ||
| return s.DeriveSubmitResponse(sOrder.ID) | ||
| } | ||
| var response *PlaceOrderResponse |
There was a problem hiding this comment.
can be shifted above smart order and used in all requests.
| } | ||
| return nil, err | ||
| smartOrder = true |
There was a problem hiding this comment.
Can just do a length check on smartOrders
| QuoteAmount: resp.Amount.Float64(), | ||
| ExecutedAmount: resp.FilledQuantity.Float64(), | ||
| RemainingAmount: resp.Quantity.Float64() - resp.FilledAmount.Float64(), | ||
| Cost: resp.Quantity.Float64() * resp.AvgPrice.Float64(), |
There was a problem hiding this comment.
resp.Quantity.Float64() -> resp.FilledQuantity.Float64() maybe there is a partial fill?
exchanges/request/request.go
Outdated
| @@ -237,6 +237,7 @@ func (r *Requester) doRequest(ctx context.Context, endpoint EndpointLimit, newRe | |||
| if err != nil { | |||
| return err | |||
| } | |||
| println(string(contents)) | |||
…r functions, and types
…dling for v3 websocket connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request included a Poloniex exchange code implementation with REST and WebSocket capabilities. The Wrapper and Web-socket functions have all undergone testing. My code conforms to the GCT style standards used by other exchanges.
golangci-lint was used to fix a few mistakes. For future use, endpoint methods that the GCT wrapper does not support are also implemented.
The PR included implementations for REST for trading and other endpoint methods, Web-socket streaming, and Trading through the web socket stream.
Fixes # (issue)
Type of change
Please delete options that are not relevant and add an
xin[]as the item is complete.How has this been tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and
also consider improving test coverage whilst working on a certain feature or package.
Checklist