Adds err processing, err channel, fix the others

exchanges/deribit/deribit.go

@@ -2705,7 +2705,7 @@ func (d *Deribit) getAssetPairByInstrument(instrument string) (currency.Pair, as
 
 	var item asset.Item
 	// Find the first occurrence of the delimiter and split the instrument string accordingly
-	parts := strings.SplitN(instrument, currency.DashDelimiter, -1)
+	parts := strings.Split(instrument, currency.DashDelimiter)
 	switch {
 	case len(parts) == 1:
 		if i := strings.IndexAny(instrument, currency.UnderscoreDelimiter); i == -1 {

exchanges/deribit/deribit_websocket.go

@@ -295,11 +295,11 @@ func (d *Deribit) wsHandleData(respRaw []byte) error {
 }
 
 func (d *Deribit) processUserOrders(respRaw []byte, channels []string) error {
-	var response WsResponse
 	if len(channels) != 4 && len(channels) != 5 {
 		return fmt.Errorf("%w, expected format 'user.orders.{instrument_name}.raw, user.orders.{instrument_name}.{interval}, user.orders.{kind}.{currency}.raw, or user.orders.{kind}.{currency}.{interval}', but found %s", errMalformedData, strings.Join(channels, "."))
 	}
-	var orderData []WsOrder
+	var response WsResponse
+	orderData := []WsOrder{}
 	response.Params.Data = orderData
 	err := json.Unmarshal(respRaw, &response)
 	if err != nil {

exchanges/deribit/deribit_wrapper.go

@@ -258,23 +258,28 @@ func (d *Deribit) UpdateTradablePairs(ctx context.Context, forceUpdate bool) err
 	assets := d.GetAssetTypes(false)
 	var wg sync.WaitGroup
 	wg.Add(len(assets))
-	var errs error
+	errC := make(chan error, len(assets))
 	for x := range assets {
 		go func(x int) {
 			defer wg.Done()
 			pairs, err := d.FetchTradablePairs(ctx, assets[x])
 			if err != nil {
-				errs = common.AppendError(errs, err)
+				errC <- err
 				return
 			}
 			err = d.UpdatePairs(pairs, assets[x], false, forceUpdate)
 			if err != nil {
-				errs = common.AppendError(errs, err)
+				errC <- err
 				return
 			}
 		}(x)
 	}
 	wg.Wait()
+	close(errC)
+	var errs error
+	for err := range errC {
+		errs = common.AppendError(errs, err)
+	}
 	return errs
 }
 
@@ -1496,8 +1501,11 @@ func (d *Deribit) GetLatestFundingRates(ctx context.Context, r *fundingrate.Late
 		return nil, fmt.Errorf("%s %w", r.Asset, asset.ErrNotSupported)
 	}
 	isPerpetual, err := d.IsPerpetualFutureCurrency(r.Asset, r.Pair)
-	if !isPerpetual || err != nil {
-		return nil, futures.ErrNotPerpetualFuture
+	if err != nil {
+		return nil, err
+	}
+	if !isPerpetual {
+		return nil, fmt.Errorf("%w '%s'", futures.ErrNotPerpetualFuture, r.Pair)
 	}
 	pFmt, err := d.CurrencyPairs.GetFormat(r.Asset, true)
 	if err != nil {