Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names not recognized after discarding changes with Source Control #564

Closed
zachpoblete opened this issue Aug 9, 2024 · 3 comments
Closed

Comments

@zachpoblete
Copy link

In the following example, the test repo contains main.ahk which calls function() and #Includes function.ahk which contains the definition of function().

These files have been commited.

image

If we close function.ahk and rename function() to functionRenamed() in main.ahk,

image

it's also renamed in function.ahk as expected, which is confirmed by function.ahk appearing as changed in the Source Control panel on the right.

image

But if we discard all our changes through the Source Control panel,

image

function() in main.ahk is not recognized as having been defined.

image

And if we try to rename function(),

image

it isn't renamed in function.ahk.

image

@zachpoblete
Copy link
Author

Probably related to #493.

@thqby
Copy link
Owner

thqby commented Aug 9, 2024

This is unrelated. When you close function.ahk, vscode will not monitor the contents of the file for changes. After git retracts the changes, vscode does not notify the extension that the content of the file has changed, thus updating the cache.

@zachpoblete
Copy link
Author

Hmm, so no way around this?

@thqby thqby closed this as completed in cbaf5ce Aug 25, 2024
mark-wiemer pushed a commit to mark-wiemer/ahk2-lsp that referenced this issue Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants