Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange highlighting of hexadecimal prefixes, zero-padded integers and floats #16

Closed
lvalkov opened this issue Jun 25, 2021 · 3 comments

Comments

@lvalkov
Copy link
Contributor

lvalkov commented Jun 25, 2021

        1111
   0.0001111

  0x00001111
   .00001111
   000001111

image
Is there a particular reason why hexadecimal numbers, zero-left-padded integers and floating point numbers without leading zeroes are being highlighted this way?
I expected them to be highlighted identically to the non-zero-padded integer and regular float (see first two lines in the screenshot).

@thqby
Copy link
Owner

thqby commented Jun 25, 2021

Screenshot_20210625_101945_com microsoft rdc android
Except for '.000001111', there does not seem to be a problem.

@lvalkov
Copy link
Contributor Author

lvalkov commented Jun 25, 2021

HexadecimalScope
If you deem keyword.other.unit.(exponent | hexadecimal | octal) to be correct scopes, being assigned correctly (this I do not contest), then I shall adjust my color scheme accordingly. From your screenshot, I can tell yours does not exhibit this issue. Thank you!

keyword.operator.dot, however, indeed does not seem to be the correct choice of scope in this particular case.

@thqby
Copy link
Owner

thqby commented Jun 25, 2021

I will merge some textmate scopes.

@thqby thqby closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants