Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password secret not detected on commit #404

Open
sarnya opened this issue Nov 2, 2022 · 0 comments
Open

Password secret not detected on commit #404

sarnya opened this issue Nov 2, 2022 · 0 comments
Assignees
@tinamthomas
Labels
bug critical

Comments

@sarnya
Copy link

sarnya commented Nov 2, 2022 •
edited
Loading

Describe the bug
Password secret not detected on commit when talisman was added as a pre-commit hook.

To Reproduce
Steps to reproduce the behaviour:

  1. Add func("password', "asdfasdfa"); to some file in the repo
  2. Make a commit

Expected behavior
Commit should fail, and talisman should show the text as a potential secret.

Desktop (please complete the following information):

  • OS: MacOS Monterey (12.6)
  • Talisman version: 1.29.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tinamthomas tinamthomas

Labels
bug critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tinamthomas @sarnya