Merge pull request #20 from thoughtspot/feat/added-version-support-fo…

…r-charts

added column level settings in custom bar chart and added versioning …

.github/workflows/static.yml

@@ -4,7 +4,7 @@ name: Deploy static content to Pages
 on:
   # Runs on pushes targeting the default branch
   push:
-    branches: ["main"]
+    branches: ['main']
 
   # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
@@ -18,7 +18,7 @@ permissions:
 # Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
 # However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
 concurrency:
-  group: "pages"
+  group: 'pages'
   cancel-in-progress: false
 
 jobs:

.gitignore

@@ -8,3 +8,4 @@ lib
 .DS_Store
 src/.DS_Store
 dist
+.vercel

ReadMe.md

@@ -9,35 +9,12 @@ npm run dev
 
 ### List of urls
 
-```
-[
-  {
-    "name": "bar-chart-with-measure-names-values",
-    "sourceUrl": "http://localhost:3002/v1/bar-chart-with-measure-names-values/"
-  },
-  {
-    "name": "combo-chart",
-    "sourceUrl": "http://localhost:3002/v1/combo-chart/"
-  },
-  {
-    "name": "custom-bar-chart",
-    "sourceUrl": "http://localhost:3002/v1/custom-bar-chart/"
-  },
-  {
-    "name": "custom-bar-react",
-    "sourceUrl": "http://localhost:3002/v1/custom-bar-react/"
-  },
-  {
-    "name": "gantt",
-    "sourceUrl": "http://localhost:3002/v1/gantt/"
-  },
-  {
-    "name": "sunburst",
-    "sourceUrl": "http://localhost:3002/v1/sunburst/"
-  },
-  {
-    "name": "tester-chart",
-    "sourceUrl": "http://localhost:3002/v1/tester-chart/"
-  }
-]
-```
+will be available here [Generate Urls](./generated_urls.json)
+
+### Versioning of charts based on TS
+
+We have introduced new folders for separate versions the folder structure apart from v1, which will contain the current charts code.
+
+- If a minimum version required to run the chart is 10.5 the path to chart code is `src/v10_5/<customcharttype-folder>`
+- We would need to update `sourceFolders` array in `vite.config.ts` for deployment.
+- The generated urls will look like http://localhost:3002/v10_5/custom-bar-chart/ for TS version 10.5 where custom-bar-chart is the folder where custom bar chart code is present.

generated_urls.json

@@ -26,5 +26,9 @@
   {
     "name": "tester-chart",
     "sourceUrl": "http://localhost:3002/v1/tester-chart/"
+  },
+  {
+    "name": "custom-bar-chart",
+    "sourceUrl": "http://localhost:3002/v10_5/custom-bar-chart/"
   }
-]
+]

package.json

@@ -23,7 +23,7 @@
     "vite-plugin-react": "^3.0.2"
   },
   "dependencies": {
-    "@thoughtspot/ts-chart-sdk": "0.0.2-alpha.16",
+    "@thoughtspot/ts-chart-sdk": "0.0.2-alpha.17",
     "chart.js": "3.5.0",
     "chartjs-plugin-datalabels": "2.2.0",
     "eslint": "8.40.0",