Start testing against a sample #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
force-pushed
the
nc-test-against-sample
branch
2 times, most recently
from
365ae0e
to
97fe79c
Compare
|
@nickcharlton I've added some more examples to the invalid sample in ed24e25 |
nickcharlton
force-pushed
the
nc-test-against-sample
branch
from
1d43946
to
c5bb451
Compare
To keep up to date with dependencies, it's really hard to know we've done it correctly without some tests and samples to check against. This provides a sample (from guides), with which we can test against in both the positive and negative cases, we include a GitHub Actions configuration too, so tests are automated. In our sample, we have `text-size` which doesn't exist in our current version of `stylelint`. We'll remove this rule in future, as for now, we override it to ensure the tests start from green. Finally, we add `lint:css` as a script to npm to allow for "self-linting" and testing the samples. https://github.com/thoughtbot/guides/tree/main/sass Co-authored-by: Luke Mitchell <LkeMitchll@users.noreply.github.com>
nickcharlton
force-pushed
the
nc-test-against-sample
branch
from
0ac8630
to
53cc520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep up to date with dependencies, it's really hard to know we've done it correctly without some tests and samples to check against.
This provides a sample (from guides), with which we can test against in both the positive and negative cases, we include a GitHub Actions configuration too, so tests are automated.
In our sample, we have
text-sizewhich doesn't exist in our current version ofstylelint. We'll remove this rule in future, as for now, we override it to ensure the tests start from green.Finally, we add
lint:cssas a script to npm to allow for "self-linting" and testing the samples.https://github.com/thoughtbot/guides/tree/main/sass