Use contrast-switch
function for buttons
#294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bourbon comes with a
contrast-switch
function which switches betweentwo colors based on the contrast to another color. In this case, we
check the contrast of the button's background color and output either
black or white for the text color. It helps to ensure button text is
accessible.
No visual difference with the button's look-and-feel occurs by using
contrast-switch
, as we were already within the acceptable contrastratio range.
This change also DRYs up the use of
$action-color
and creates a bettersystem to add further variations of button colors in the future.
Meaning, you can easily add something like
$_button-secondary-background-color
when the time comes.Finally, this closely mimics the variables we have set up in the
_forms
partial, as well.