Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table layout #288

Merged
merged 1 commit into from
May 26, 2017
Merged

Improve table layout #288

merged 1 commit into from
May 26, 2017

Commits on May 26, 2017

  1. Improve table layout

    - Increase bottom and top margin on tables
      - This matches the same bottom and top margin values we set on `hr`
        elements.
    - Move `text-align` property to `table`
      - In most situations, left-aligned text within a table is ideal. This
        makes sure the whole table is left-aligned, while still allowing
        easy overriding on a per-column basis (e.g. for numeral data).
    - Change vertical alignment of tables
      - Vertically aligning cell text in the middle makes for a bad reading
        experience because there is no consistent or expected starting point
        for text that the eyes can pick up on.
      - This changes the vertical alignment of cell text to:
        - Bottom of the cell in the table header (`thead`)
        - Top of the cell in the table body (`tbody`)
    - Set table borders on the row
      - Rather than setting borders on each individual cell, this sets it on
        the whole row (`tr`).
    - Use the headings line-height in table headers
    - Add padding to the right of each table cell
      - This prevents adjacement cell text from butting into each other.
    tysongach committed May 26, 2017
    Configuration menu
    Copy the full SHA
    5bb2297 View commit details
    Browse the repository at this point in the history