Implement client-side with Stimulus #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
importmaps-rails
branch
from
ba82d43 to
51e0302
Compare
seanpdoyle
force-pushed
the
importmaps-rails
branch
from
51e0302 to
a38f289
Compare
seanpdoyle
force-pushed
the
stimulus
branch
2 times, most recently
from
d920072 to
b0bccc4
Compare
seanpdoyle
force-pushed
the
stimulus
branch
2 times, most recently
from
a78a5ca to
ee358f4
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
seanpdoyle
force-pushed
the
stimulus
branch
3 times, most recently
from
984f9ff to
8e8dbb2
Compare
Depend on [@hotwired/stimulus][] on the client-side. Add the client-side dependency for `@hotwired/stimulus` to the `package.json`, , then scaffold out the changes to the `application.js` and `controllers/index.js` modules. Next, migrate the jQuery-powered code into controllers: the `select` controller to integrate with `selectize.js` and the `table` controller to manage `<table>` elements. Finally, render each necessary field (`belongs_to`, `has_many`, `polymorphic`, `select`) with the `[data-controller="select"]` attribute (powered by a new `Field#html_controller` method. [@hotwired/stimulus]: https://stimulus.hotwired.dev
nickcharlton
force-pushed
the
stimulus
branch
from
8e8dbb2 to
d38f8fa
Compare
|
Thanks for keeping this up to date! I just did a quick click around in the demo to double-check everything, but I'll merge this once the suite passes again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on @hotwired/stimulus on the client-side. Add the client-side
dependency for
@hotwired/stimulusto thepackage.json, , thenscaffold out the changes to the
application.jsandcontrollers/index.jsmodules.Next, migrate the jQuery-powered code into controllers: the
selectcontroller to integrate with
selectize.jsand thetablecontrollerto manage
<table>elements.Finally, render each necessary field (
belongs_to,has_many,polymorphic,select) with the[data-controller="select"]attribute(powered by a new
Field#html_controllermethod.