Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Field::HasOne options documentation #2375

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

littleforest
Copy link
Contributor

@littleforest littleforest commented Apr 28, 2023

This updates the documentation for customizing the Field::HasOne with the order option, which was added in #2325. This also changes each of the field descriptions to an h4 tag for better accessibility and to provide links to those headers.

Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can we split out the heading change into another PR? I wonder if it's worth seeing if other pages have the same problem when doing that too. What do you think?

@littleforest
Copy link
Contributor Author

Can we split out the heading change into another PR?

Sure, will do!

@littleforest littleforest merged commit 44ad6ce into main May 10, 2023
@littleforest littleforest deleted the update-has-one-docs branch May 10, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants