remove password field from Extending Administrate Section #2046
Conversation
ewertoncodes
changed the title
|
that PR makes sense? @pablobm |
|
I think the |
There was a problem hiding this comment.
Hello @ewertoncodes, and thank you for the PR. Apologies for the delay.
I think the change makes sense, although it would need to also change the phrasing in the sentence right before the list, as these are not the "most popular ones" any more, but rather a hand picked selection. (See my suggestion).
Perhaps also add a new fifth one, like the jsonb plugin?
Regarding @getaaron's suggestion, I'm not sure it's the same, as the belongs_to_search plugin is different from the built-in belongs_to field. However the plugin is quite tricky to use (or was last time I checked) so perhaps it's worth removing it too.
Thoughts?
ewertoncodes
force-pushed
the
patch-1
branch
from
c9ba37a to
94562fa
Compare
|
@pablobm and @nickcharlton. Looks like the circle ci needs an update on line: https://github.com/thoughtbot/administrate/blob/main/.circleci/config.yml#L10. |
|
@ewertoncodes - I just fixed the CI: it required upgrading Rails. Could you please rebase now and I'll merge? |
Remove password field from Extending Administrate section. Because password field already exist in the gem administrate.
ewertoncodes
force-pushed
the
patch-1
branch
from
94562fa to
314b2ae
Compare
|
PR updated |
|
Merged! Thank you @ewertoncodes 🙂 |
Remove password field from Extending Administrate section. Because password field already exist in the gem administrate.