feat: refactor page redirect target path #1973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make us easier to override redirect path
pablobm
reviewed
May 13, 2021
There was a problem hiding this comment.
This looks good! Yes, please provide specs and docs.
For the specs, I think the simplest way would be to create a file spec/controllers/admin/application_controller_spec.rb and use the "Anonymous controller" feature of RSpec: https://relishapp.com/rspec/rspec-rails/v/5-0/docs/controller-specs/anonymous-controller
Let me know if you have any questions.
|
@saiqulhaq and @pablobm , can I provide specs and docs for this PR? |
|
yes please |
|
Continued at #1995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will make us easier to override redirect path
should I make test & update the doc?