Add translations for ActiveRecord models #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @mgrachev! Sorry I haven't responded sooner. Could you add some tests for this? Maybe something like this, in it "honors model translations" do
allow(I18n).to receive(:translate).with("customer").and_return("user")
visit admin_customers_path
sidebar = find(".sidebar__list")
expect(sidebar).to have_link("Users")
expect(page).to have_header("Users")
end |
| @@ -11,7 +11,7 @@ as defined by the DashboardManifest. | |||
| <% DashboardManifest::DASHBOARDS.each do |resource| %> | |||
| <li> | |||
| <%= link_to( | |||
| resource.to_s.titleize, | |||
| resource.to_s.classify.constantize.model_name.human(default: resource.to_s.titleize), | |||
There was a problem hiding this comment.
Do we want to pluralize this?
There was a problem hiding this comment.
No. The user decides how to display the model name through a file locale. In default pluralization.
| @@ -8,4 +8,14 @@ | |||
|
|
|||
| expect(active_link.text).to eq "Customers" | |||
| end | |||
|
|
|||
| it "displays translated name of model" do | |||
| allow(Customer.model_name).to receive(:human).and_return('Users') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Added test |
|
Please, restart the build on CircleCI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Added translation support for ActiveRecord models in the sidebar and on the index page (header).
File locale must be of such content: