Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to sassc-rails. #1197

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Switch to sassc-rails. #1197

merged 1 commit into from
Apr 19, 2019

Conversation

nickcharlton
Copy link
Member

Ruby Sass will reach end of life on 26th Match 2019. This switches to
sassc-rails and drops the appraisal for Sass 3.4.

Currently, sassc-rails still has sass as a dependency hence this is still
included in the Gemfile.lock.

See: rails/sass-rails#420

Fixes #1196.

@krzysiek1507
Copy link
Contributor

krzysiek1507 commented Aug 7, 2018

Unfortunately, it breaks heroku builds with error:

Installing sassc 1.12.1 with native
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

I couldn't see buildpacks for libsass 3.5.2.

@nickcharlton
Copy link
Member Author

@krzysiek1507
Copy link
Contributor

I have heroku-16.

@nickcharlton
Copy link
Member Author

@krzysiek1507 Huh, interesting!

I've been trying out adjusting the way the prototype app works so that I could deploy a Heroku Review App to try this PR out. It's also running heroku-16 and with the heroku/ruby buildpack.

Is there perhaps something else your app is doing that's causing this?

@krzysiek1507
Copy link
Contributor

krzysiek1507 commented Aug 10, 2018

Does it compile w/o problems? Did you add any buildpack expect heroku/ruby?

@nickcharlton
Copy link
Member Author

It's using just heroku/ruby:

administrate/app.json

Lines 38 to 41 in 2c54226

"buildpacks": [
{
"url": "heroku/ruby"
}

Here's the build log: https://gist.github.com/nickcharlton/05d7cd0828b2e786571fa5110abe0adb

@krzysiek1507
Copy link
Contributor

Weird. I was trying to use sassc-ruby in sinatra app a few weeks ago and it didn't work.
I'll check it again on Monday.

@nickcharlton
Copy link
Member Author

@krzysiek1507 Where you able to check out your example in the end?

@archonic
Copy link

archonic commented Apr 5, 2019

I think it's safe to say there's a way to install sassc on heroku these days. Even if there wasn't, I don't think this gem would need take ownership of those issues. We're now past EOL. Think we can merge this @nickcharlton?

@krzysiek1507
Copy link
Contributor

Sorry for the delay. I didn't make it work on heroku but, I think, a buildpack with libsass should make it work.

@nickcharlton nickcharlton force-pushed the nc-switch-to-sassc branch 3 times, most recently from 863a8c7 to 5412ba1 Compare April 19, 2019 22:38
Ruby Sass reached end of life on 26th Match 2019. This switches to
`sassc-rails` and drops the appraisal for Sass 3.4.

Fixes #1196.
@nickcharlton nickcharlton merged commit 9e216f8 into master Apr 19, 2019
@nickcharlton nickcharlton deleted the nc-switch-to-sassc branch April 19, 2019 23:07
pablobm added a commit to pablobm/administrate that referenced this pull request May 26, 2022
Should have been removed as part of thoughtbot#1197
nickcharlton pushed a commit that referenced this pull request Aug 8, 2022
Rails 5.0 and 5.1 already reached end-of-life, and 5.2 will reach it
next week. Time to drop support for them.

Additionally, removed gemfiles/sass_3_4.gemfile, which was a
leftover from #1197

https://guides.rubyonrails.org/maintenance_policy.html#severe-security-issues
#1197
KingTiger001 added a commit to KingTiger001/admin-Rails-project that referenced this pull request Jan 15, 2023
Rails 5.0 and 5.1 already reached end-of-life, and 5.2 will reach it
next week. Time to drop support for them.

Additionally, removed gemfiles/sass_3_4.gemfile, which was a
leftover from #1197

https://guides.rubyonrails.org/maintenance_policy.html#severe-security-issues
thoughtbot/administrate#1197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby Sass is deprecated and will be unmaintained as of 26 March 2019.
3 participants