-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to sassc-rails. #1197
Switch to sassc-rails. #1197
Conversation
Unfortunately, it breaks heroku builds with error:
I couldn't see buildpacks for |
@krzysiek1507 According to the |
I have |
ff72788
to
2278a75
Compare
@krzysiek1507 Huh, interesting! I've been trying out adjusting the way the prototype app works so that I could deploy a Heroku Review App to try this PR out. It's also running Is there perhaps something else your app is doing that's causing this? |
Does it compile w/o problems? Did you add any buildpack expect |
It's using just Lines 38 to 41 in 2c54226
Here's the build log: https://gist.github.com/nickcharlton/05d7cd0828b2e786571fa5110abe0adb |
Weird. I was trying to use |
@krzysiek1507 Where you able to check out your example in the end? |
I think it's safe to say there's a way to install sassc on heroku these days. Even if there wasn't, I don't think this gem would need take ownership of those issues. We're now past EOL. Think we can merge this @nickcharlton? |
Sorry for the delay. I didn't make it work on heroku but, I think, a buildpack with libsass should make it work. |
863a8c7
to
5412ba1
Compare
Ruby Sass reached end of life on 26th Match 2019. This switches to `sassc-rails` and drops the appraisal for Sass 3.4. Fixes #1196.
5412ba1
to
fa8e14d
Compare
Should have been removed as part of thoughtbot#1197
Rails 5.0 and 5.1 already reached end-of-life, and 5.2 will reach it next week. Time to drop support for them. Additionally, removed gemfiles/sass_3_4.gemfile, which was a leftover from #1197 https://guides.rubyonrails.org/maintenance_policy.html#severe-security-issues #1197
Rails 5.0 and 5.1 already reached end-of-life, and 5.2 will reach it next week. Time to drop support for them. Additionally, removed gemfiles/sass_3_4.gemfile, which was a leftover from #1197 https://guides.rubyonrails.org/maintenance_policy.html#severe-security-issues thoughtbot/administrate#1197
Ruby Sass will reach end of life on 26th Match 2019. This switches to
sassc-rails
and drops the appraisal for Sass 3.4.Currently,
sassc-rails
still hassass
as a dependency hence this is stillincluded in the
Gemfile.lock
.See: rails/sass-rails#420
Fixes #1196.