Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey spec: Search admin search with a filter with arguments #2523

Closed
nickcharlton opened this issue Feb 16, 2024 · 1 comment
Closed

Flakey spec: Search admin search with a filter with arguments #2523

nickcharlton opened this issue Feb 16, 2024 · 1 comment
Labels
bug breakages in functionality that is implemented railsconf2024 Issues worked on during RailsConf 2024 Hack Day

Comments

@nickcharlton
Copy link
Member

Flakey, but consistently flakey since we merged in #2448.

Failures:

  1) Search admin searches with a filter with arguments
     Failure/Error: expect(page).not_to have_content(standard_match.email)
       expected not to find text "me@kind.com" in "Back to app\nCustomers\nLog Entries\nOrders\nPages\nProducts\nProduct Meta Tags\nPayments\nSeries\nBlog Posts\nBlog Tags\nStats\nCustomers\nYou are logged in as Admin.\nNew customer\nEmail Email Subscriber Lifetime Value Name Orders Log Entries Kind Territory Password\nvip@kind.com - $0.00 Customer 157 0 orders 0 log entries vip Country 201 Edit\nBecome\nme@kind.com - $0.00 Customer 158 0 orders 0 log entries standard Country 202 Edit\nBecome\nstandard@kind.com - $0.00 Customer 159 0 orders 0 log entries vip Country 203 Edit\nBecome"
     # ./spec/features/search_spec.rb:105:in `block (2 levels) in <top (required)>'
     # /Users/nickcharlton/.gem/ruby/3.2.2/gems/webmock-3.20.0/lib/webmock/rspec.rb:39:in `block (2 levels) in <top (required)>'

Finished in 14.98 seconds (files took 2.49 seconds to load)
579 examples, 1 failure

Failed examples:

rspec ./spec/features/search_spec.rb:88 # Search admin searches with a filter with arguments

Randomized with seed 33089
@nickcharlton nickcharlton added the bug breakages in functionality that is implemented label Feb 16, 2024
This was referenced Feb 16, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 27, 2024
Merged
Merged
Merged
Merged
Closed
nickcharlton added a commit that referenced this issue Mar 1, 2024
@nickcharlton
Fix "search with a filter with arguments" spec
6376ad6 
Since we merged in #2448, this has been repeatedly failing on CI. It
doesn't fail locally, which makes it hard to debug.

Fixes #2523
nickcharlton added a commit that referenced this issue Mar 1, 2024
@nickcharlton
Fix "search with a filter with arguments" spec
c2fa5c4 
Since we merged in #2448, this has been repeatedly failing on CI. It
doesn't fail locally, which makes it hard to debug.

Fixes #2523
This was referenced Mar 15, 2024
Merged
Merged
Merged
Merged
Merged
@nickcharlton nickcharlton mentioned this issue Mar 27, 2024
Merged
@sdwolfz sdwolfz mentioned this issue Mar 28, 2024
Merged
@nickcharlton nickcharlton mentioned this issue Mar 28, 2024
Merged
@nickcharlton nickcharlton mentioned this issue Apr 12, 2024
Merged
This was referenced May 3, 2024
Merged
Merged
Merged
Merged
@mike-burns
Copy link
Contributor

https://stackoverflow.com/questions/11980109/cucumber-capybara-check-that-a-page-does-not-have-content#comment134688856_35640662

I wonder (also don't have time to work on this right now), what if we swapped lines 106 and 105. Would that cause Capybara to wait correctly?

@stefannibrasil stefannibrasil added the railsconf2024 Issues worked on during RailsConf 2024 Hack Day label May 8, 2024
@CaleCrawford CaleCrawford mentioned this issue May 9, 2024
Merged
nickcharlton pushed a commit to CaleCrawford/administrate that referenced this issue May 14, 2024
@CaleCrawford @nickcharlton
Fix "search with a filter with arguments" spec
cff1129 
The flake would happen when the second search of `kind:vip` was not
applied to the URL. Running the test directly in Chrome would show it
happening. As the URL parameter was never set, it was therefore blank.
Whilst a `sleep(0.1)` would fix it, this instead restructures the test
to avoid the problem completely.

Closes thoughtbot#2523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug breakages in functionality that is implemented railsconf2024 Issues worked on during RailsConf 2024 Hack Day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "search with a filter with arguments" spec thoughtbot/administrate
3 participants
@mike-burns @nickcharlton @stefannibrasil