Skip to content

Commit

Permalink
Clean up really odd examples of Field::Deferred
Browse files Browse the repository at this point in the history
  • Loading branch information
pablobm committed Jul 9, 2020
1 parent d49cbad commit fd26c5c
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 14 deletions.
33 changes: 21 additions & 12 deletions spec/lib/fields/deferred_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@
describe "#permitted_attribute" do
context "when given a `foreign_key` option" do
it "returns the value given" do
deferred = Administrate::Field::Deferred.
new(Administrate::Field::BelongsTo.with_options(foreign_key: :bar))
deferred = Administrate::Field::Deferred.new(
Administrate::Field::BelongsTo,
foreign_key: :bar,
)
expect(deferred.permitted_attribute(LineItem, :foo)).to eq(:bar)
end
end

context "when not given a `foreign_key` option" do
it "delegates to the backing class" do
deferred = Administrate::Field::Deferred.
new(Administrate::Field::String)
deferred = Administrate::Field::Deferred.new(
Administrate::Field::String
)
allow(Administrate::Field::String).to receive(:permitted_attribute)

deferred.permitted_attribute(LineItem, :foo)
Expand All @@ -30,10 +33,14 @@
describe "#searchable?" do
context "when given a `searchable` option" do
it "returns the value given" do
searchable_deferred = Administrate::Field::Deferred.
new(double(searchable?: false), searchable: true)
unsearchable_deferred = Administrate::Field::Deferred.
new(double(searchable?: true), searchable: false)
searchable_deferred = Administrate::Field::Deferred.new(
double(searchable?: false),
searchable: true,
)
unsearchable_deferred = Administrate::Field::Deferred.new(
double(searchable?: true),
searchable: false,
)

expect(searchable_deferred.searchable?).to eq(true)
expect(unsearchable_deferred.searchable?).to eq(false)
Expand All @@ -42,10 +49,12 @@

context "when not given a `searchable` option" do
it "falls back to the default of the deferred class" do
searchable_deferred = Administrate::Field::Deferred.
new(double(searchable?: true))
unsearchable_deferred = Administrate::Field::Deferred.
new(double(searchable?: false))
searchable_deferred = Administrate::Field::Deferred.new(
double(searchable?: true),
)
unsearchable_deferred = Administrate::Field::Deferred.new(
double(searchable?: false),
)

expect(searchable_deferred.searchable?).to eq(true)
expect(unsearchable_deferred.searchable?).to eq(false)
Expand Down
6 changes: 4 additions & 2 deletions spec/lib/fields/has_one_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@
describe ".permitted_attribute" do
context "with custom class_name" do
it "returns attributes from correct dashboard" do
field = Administrate::Field::Deferred.new(Administrate::Field::HasOne.
with_options(class_name: :product_meta_tag))
field = Administrate::Field::Deferred.new(
Administrate::Field::HasOne,
class_name: :product_meta_tag,
)

field_name = "product_meta_tag"
attributes = field.permitted_attribute(Product, field_name)
Expand Down

0 comments on commit fd26c5c

Please sign in to comment.