Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log at notice level during CI #3338

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Log at notice level during CI #3338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
242d5e6
Log at notice level during CI
Tatskaari Jan 23, 2025
6e0f606
Do it this way so it doesn't affect the e2e tests
Tatskaari Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
- image: thoughtmachine/please_alpine:20240906
resource_class: large
environment:
PLZ_ARGS: "-p --profile ci --profile alpine --exclude no-musl"
PLZ_ARGS: "--profile ci --profile alpine --exclude no-musl"
steps:
- checkout
- restore_cache:
Expand All @@ -22,7 +22,7 @@ jobs:
path: plz-out/results
- run:
name: Package
command: plz-out/bin/src/please build //package:all -p --profile ci --profile alpine
command: plz-out/bin/src/please build //package:all -p -v2 --profile ci --profile alpine
- persist_to_workspace:
root: plz-out/pkg
paths:
Expand All @@ -46,7 +46,7 @@ jobs:
- image: thoughtmachine/please_ubuntu:20240906
resource_class: large
environment:
PLZ_ARGS: "-p --profile ci"
PLZ_ARGS: "--profile ci"
steps:
- checkout
- restore_cache:
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
- image: thoughtmachine/please_ubuntu_alt:20240910
resource_class: large
environment:
PLZ_ARGS: "-p -c cover --profile ci-alt"
PLZ_ARGS: "-c cover --profile ci-alt"
PLZ_COVER: "cover --nocoverage_report"
steps:
- checkout
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
command: tar -xzf /tmp/workspace/darwin_arm64/please_*.tar.gz
- run:
name: Cross-compile
command: ./please/please build -p --profile ci --arch darwin_amd64 -o plugin.go.cgoenabled:true -o plugin.go.cctool:clang -o "plugin.go.cflags:-target x86_64-apple-macos13" //package:release_files
command: ./please/please build -p -v2 --profile ci --arch darwin_amd64 -o plugin.go.cgoenabled:true -o plugin.go.cctool:clang -o "plugin.go.cflags:-target x86_64-apple-macos13" //package:release_files
- persist_to_workspace:
root: plz-out/pkg
paths:
Expand All @@ -167,7 +167,7 @@ jobs:
command: tar -xzf /tmp/workspace/linux_amd64/please_*.tar.gz
- run:
name: Cross-compile
command: ./please/please build -p --profile ci --arch freebsd_amd64 //package:release_files
command: ./please/please build -p -v2 --profile ci --arch freebsd_amd64 //package:release_files
- persist_to_workspace:
root: plz-out/pkg
paths:
Expand All @@ -193,7 +193,7 @@ jobs:
command: tar -xzf /tmp/workspace/linux_amd64/please_*.tar.gz
- run:
name: Cross-compile
command: ./please/please build -p --profile ci --arch linux_arm64 -o please.location:~/please/please //package:release_files
command: ./please/please build -p -v2 --profile ci --arch linux_arm64 -o please.location:~/please/please //package:release_files
- persist_to_workspace:
root: plz-out/pkg
paths:
Expand All @@ -208,7 +208,7 @@ jobs:
xcode: "13.4.1"
resource_class: macos.m1.medium.gen1
environment:
PLZ_ARGS: "-p --profile ci --exclude pip --exclude embed"
PLZ_ARGS: "--profile ci --exclude pip --exclude embed"
steps:
- checkout
- restore_cache:
Expand Down
2 changes: 1 addition & 1 deletion bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ PLZ_ARGS="${PLZ_ARGS:-}"

# Now invoke Go to run Please to build itself.
notice "Bootstrapping please..."
go run -race src/please.go $PLZ_ARGS --log_file plz-out/log/bootstrap_build.log build //src:please
go run -race src/please.go -p -v2 $PLZ_ARGS --log_file plz-out/log/bootstrap_build.log build //src:please

if [ $# -gt 0 ] && [ "$1" == "--skip_tests" ]; then
notice "Skipping tests... done."
Expand Down
4 changes: 2 additions & 2 deletions test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ eval `go env`
# repo that are optional and exercise specific rules, and require extra dependencies.
EXCLUDES=$(check_path_for_excludes)

plz-out/bin/src/please $PLZ_ARGS ${PLZ_COVER:-test} $EXCLUDES --exclude=e2e --log_file plz-out/log/test_build.log --log_file_level 4 --trace_file plz-out/log/trace.json $@
plz-out/bin/src/please -p -v2 $PLZ_ARGS ${PLZ_COVER:-test} $EXCLUDES --exclude=e2e --log_file plz-out/log/test_build.log --log_file_level 4 --trace_file plz-out/log/trace.json $@

# We run the end-to-end tests separately to ensure things don't fight with one another; they are
# finicky about some things due to running plz recursively and disabling the lock.
notice "Running end-to-end tests..."
plz-out/bin/src/please $PLZ_ARGS ${PLZ_COVER:-test} $EXCLUDES --include=e2e --log_file plz-out/log/e2e_build.log --log_file_level 4 $@
plz-out/bin/src/please -p -v2 $PLZ_ARGS ${PLZ_COVER:-test} $EXCLUDES --include=e2e --log_file plz-out/log/e2e_build.log --log_file_level 4 $@
Loading