Change to use third-party go test parser #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterebden
commented
Sep 3, 2023
| results_test.go:11: Unable to parse file: EOF | ||
| --- FAIL: TestJSONExpectedFailure-6 (0.00s) |
There was a problem hiding this comment.
I'm not fully certain about all the logic here but I don't observe this ordering happening to me when tests fail.
| interactive_display_test.go:21: haven't written proper support for this yet | ||
| --- SKIP: TestLimitedPrintfAnsiNotCountedWhenReducing (0.00s) |
There was a problem hiding this comment.
Similarly here, the skip message appears between the RUN and SKIP lines
| @@ -169,11 +169,6 @@ func TestGoIgnoreUnknownOutput(t *testing.T) { | |||
| assert.Equal(t, 0, results.Skips()) | |||
| } | |||
|
|
|||
| func TestGoFailIfUnknownTestPasses(t *testing.T) { | |||
There was a problem hiding this comment.
I think go-junit-report handles the case we test here (of results happening out of order). I'm not sure to what degree we need to care.
samwestmoreland
approved these changes
Sep 4, 2023
|
Alright I'm going to land this and we'll see how we go. If we have to revert it again at least we'll try to remember why this time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recall us looking at this sort of thing in the past but can't recall why we didn't just use it. I like the idea of us having a bunch less code here.
Have fiddled with a few cases and this seems reasonable. It's definitely broadly working, unsure if maybe there is some edge case that is worse.
One minor change: on test failures we now emit just the failure and not stdout. I think this is better, Go tests tended to feel overly verbose before with the doubled output.
I've also rediscovered what I previously knew about
go test -json: it is not inherently part of the test, it is a separate binary that still parses the (very similar) output. Seems not worth going through another subprocess given this can just parse it directly.