Skip to content

Commit

Permalink
packager: TerminalReporter: stop reporting global cache errors
Browse files Browse the repository at this point in the history
Summary: At FB we log errors into the error infra, and these errors are not actionnable for end users, so let's reduce the noise generated on the terminal. In the OSS case, people can simply add a handler in a TerminalReporter decorator, the same way we do internally (anyhow, I do not know of anyone using the global cache in OSS for now).

Reviewed By: davidaurelio

Differential Revision: D4762858

fbshipit-source-id: 880c02e175ae551df11b7ce273acc318222c46bf
  • Loading branch information
Jean Lauliac authored and thotegowda committed May 7, 2017
1 parent 341c54c commit a41e565
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packager/src/lib/TerminalReporter.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,6 @@ class TerminalReporter {
case 'dep_graph_loaded':
terminal.log(`${DEP_GRAPH_MESSAGE}, done.`);
break;
case 'global_cache_error':
const message = JSON.stringify(event.error.message);
reporting.logWarning(terminal, 'the global cache failed: %s', message);
break;
case 'global_cache_disabled':
this._logCacheDisabled(event.reason);
break;
Expand Down

0 comments on commit a41e565

Please sign in to comment.