Updates w.r.t. web-eid #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed everything related to old id-card setup (incl mixin, base view, nginx testing helpers and documentation for it).
…request.Session used for api calls The downstream users are able to define their own session adapter that handles proxying traffic between the apis and the caller.
Update sign buttons with new branding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esteid-helper bundled under
esteid-newandesteid-teststatic folders has been removed.LegacyIdentificationManagerinstead ofIdentificationManagerChanged:
IdentificationManager.getErrornow expects the entire error object as its argument instead of only the error message value. See changes inesteid/templates/esteid/test-new.htmlandesteid/templates/esteid/test.htmlfor an example on how to update your code.Changed: Changed django imports to work in a backwards compatible manner to allow usage with old django on the users own risk.
Changed: Due to the changes in the underlying infrastrucuture the certificate and signature values sent to server during id-card signing are now base64 encoded instead of hex encoded. This should not affect the users of the library unless you are interfacing with the values directly in your own code.