Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Resolve: [Ledger] Add wallet index input for RUNE #1889

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Resolve: [Ledger] Add wallet index input for RUNE #1889

merged 3 commits into from
Oct 27, 2021

Conversation

gromxyz
Copy link
Contributor

@gromxyz gromxyz commented Oct 27, 2021

Closes #1888

@gromxyz gromxyz self-assigned this Oct 27, 2021
@gromxyz gromxyz requested a review from veado October 27, 2021 10:20
veado
veado suggested changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just few nitpick...

src/main/api/ledger/transaction.ts Outdated Show resolved Hide resolved
src/renderer/components/wallet/settings/WalletSettings.tsx Outdated Show resolved Hide resolved
src/renderer/components/wallet/settings/WalletSettings.tsx Show resolved Hide resolved
src/main/api/ledger/transaction.ts Show resolved Hide resolved
veado
veado approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gromxyz gromxyz merged commit 1403328 into develop Oct 27, 2021
@gromxyz gromxyz deleted the issue-1888/ledger-rune-wallet-index branch October 27, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@veado veado veado approved these changes

Assignees

@gromxyz gromxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ledger] Add wallet index input for RUNE
2 participants
@gromxyz @veado