This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Resolve: Update to latest npm dependencies (19-10-2021) #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veado
suggested changes
Oct 19, 2021
There was a problem hiding this comment.
Issue
Latest changes do not work on Linux, yarn dev failed:
[dev:electron] A JavaScript error occurred in the main process
[dev:electron] Uncaught Exception:
[dev:electron] Error: The module 'node_modules/usb-detection/build/Release/detection.node'
[dev:electron] was compiled against a different Node.js version using
[dev:electron] NODE_MODULE_VERSION 89. This version of Node.js requires
[dev:electron] NODE_MODULE_VERSION 98. Please try re-compiling or re-installing
Following steps did not work:
- Install everything from scratch
rm yarn.lock&&rm -rf node_modules&& yarn` - Re-build native modules using
./node_modules/.bin/electron-rebuild(as described in README ofnode-usb-detection, chapter Install for Electron) - Running different Node versions: v15 + v16
Downgrade "@ledgerhq/hw-transport": "^6.2.0", "@ledgerhq/hw-transport-node-hid-singleton": "^6.2.0" (same versions insee UPDATE belowledger-thorchain-js)
UPDATE:
- Downgrade to previous version of "@ledgerhq/hw-transport-node-hid-singleton" did not work, because it still changes to latest
usb-detection@0.13.0inyarn.lock - Commit 567eb33 (Downgrade
@ledgerhq/hw-transport-node-hid-singletonAND stickusb-detection@4.10.0) finally fixes all this issue - check Resolve: Update to latest npm dependencies (19-10-2021) #1864 (comment)
+ update yarn.lock to stick with usb-detection@4.10.0 by reverting changes in `resolved` url All needed to avoid issues of running usb-detection behind the scenes - see #1864 (review) for more details
veado
reviewed
Oct 19, 2021
yarn.lock
Outdated
Comment on lines
19117
to
19118
| resolved "https://registry.yarnpkg.com/usb-detection/-/usb-detection-4.10.0.tgz#0f8a3b8965a5e4e7fbee1667971ca97e455ed11f" | ||
| integrity sha512-YUzVWXwfSviE2pInXCKYXhR5heY9GUzlWsdZYxb/Br1Xela6P31A0KDHm7XW0Wsku1HwrokZx+/OD8cZSPHR3w== |
There was a problem hiding this comment.
Sticking to sources of usb-detection-4.10.0 are important here.
veado
approved these changes
Oct 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify commands:
yarn prebuildyarn generate:typesyarn build-storybookyarn storybookVerify functionality:
ETH.RUNEandBNB.RUNENot updated:
@storybook/react- mentioned in Resolve: Update npm dependencies (06-23-2021) #1579ts-loader- mentioned in update deps 07 05 2021 #1411cosmos-client- waiting on Upgrade cosmos and thorchain to use 0.42.14 cosmos-client xchainjs/xchainjs-lib#436 in order to upgrade bothrxjs- a lot of changes in the code required to support newest versionusb-detection-4.10.0(see Resolve: Update to latest npm dependencies (19-10-2021) #1864 (comment))Closes #1863
Closes #1862