Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created New TUnit Aspire templates #1880

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

licon4812
Copy link

@licon4812 licon4812 commented Feb 18, 2025

I have added two new template types to the template pack. This feature Resolves #1875

TUnit.Aspire which is based on the .NET Aspire NUnit Template

TUnit.AspireStarter is based on the .NET Aspire Starter template and creates the following project types. The projects are prefixed with Example.Namespace so that the projects will be prefixed with the user's namespace on project creation. Eg MyNamespace.TestProject, or MyNamespace.Apphost.

  • ApiService
  • AppHost
  • ServiceDefaults
  • TestProject
  • WebApp

@licon4812
Copy link
Author

The pending code quality issues are mainly default Aspire template stuff. How would you like me to proceed?

@thomhurst
Copy link
Owner

The pending code quality issues are mainly default Aspire template stuff. How would you like me to proceed?

That's fine - Don't worry about it.

@thomhurst
Copy link
Owner

Wondering if we can come up with better names?

TUnit.Aspire and TUnit.AspireStarter feel too similar to me and don't clearly tell you which is which or what the difference is.

I also think an extra full stop would be better e.g. TUnit.Aspire.Starter

licon4812 and others added 3 commits February 19, 2025 09:34
@licon4812
Copy link
Author

Wondering if we can come up with better names?

TUnit.Aspire and TUnit.AspireStarter feel too similar to me and don't clearly tell you which is which or what the difference is.

I also think an extra full stop would be better e.g. TUnit.Aspire.Starter

I have renamed TUnit.Aspire to TUnit.Aspire.Test. I have also fixed TUnit.Aspire.Starter. As for the name of the starter template. It loosely matches the Aspire Starter template that the Aspire team provides. Happy to update the naming in the template.config if you think it can match better.

image
image

@licon4812
Copy link
Author

@thomhurst, I have fixed all the reviews you left. Feel free to let me know if there is anything else I need to fix.

Thank you for the assistance with this 😊

@licon4812
Copy link
Author

Should be ready to go now @thomhurst

auto-merge was automatically disabled February 23, 2025 00:14

Head branch was pushed to by a user without write access

@thomhurst thomhurst enabled auto-merge (squash) February 23, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Template] TUnit Aspire templates
2 participants